----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24257/ -----------------------------------------------------------
Review request for drill. Repository: drill-git Description ------- The current parquet writer does not handle complex types. And there currently is no json writer. The goal is to enhance the record writer interface to handle complex types, and implement this for parquet and json. The text writer will also handle complex types, by printing out the JSON object when the field is complex. Diffs ----- exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java 6a7fb86 exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java b58f24c exec/java-exec/src/main/codegen/templates/JsonOutputRecordWriter.java PRE-CREATION exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java 5284199 exec/java-exec/src/main/codegen/templates/RecordValueAccessor.java d4c6817 exec/java-exec/src/main/codegen/templates/RecordWriter.java 2334a14 exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java 9f0d701 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java 29b346d exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java a2d22cf exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java 7fbb9c7 exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java a336316 exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordWriter.java 55f2b72 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java cb77032 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java 5350662 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 1cb0d06 exec/java-exec/src/test/resources/donuts.json PRE-CREATION protocol/src/main/java/org/apache/drill/common/types/MinorType.java 772e2ff Diff: https://reviews.apache.org/r/24257/diff/ Testing ------- Thanks, Steven Phillips
