----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24345/ -----------------------------------------------------------
(Updated Aug. 7, 2014, 8:33 a.m.) Review request for drill, Aditya Kishore and Mehant Baid. Changes ------- Implemented review comments ! Repository: drill-git Description ------- Implemented Drill Function IsNumeric for DRILL-1141 Diffs (updated) ----- exec/java-exec/src/main/codegen/config.fmpp ff6135d exec/java-exec/src/main/codegen/data/NumericTypes.tdd f37a3dd exec/java-exec/src/main/codegen/templates/NumericFunctionsTemplates.java PRE-CREATION exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java 62a224e exec/java-exec/src/test/resources/functions/testIsNumericFunction.json PRE-CREATION Diff: https://reviews.apache.org/r/24345/diff/ Testing ------- Yes. Test Case: $mvn test -Dtest=TestNewMathFunctions#testIsNumeric Sqlline Test: 0: jdbc:drill:zk=local> SELECT employee_id, isnumeric(employee_id) isnumeric_1, first_name, isnumeric(first_name) isnumeric_2 FROM cp.`employee.json` limit 10; +-------------+-------------+------------+-------------+ | employee_id | isnumeric_1 | first_name | isnumeric_2 | +-------------+-------------+------------+-------------+ | 1 | 1 | Sheri | 0 | | 2 | 1 | Derrick | 0 | | 4 | 1 | Michael | 0 | | 5 | 1 | Maya | 0 | | 6 | 1 | Roberta | 0 | | 7 | 1 | Rebecca | 0 | | 8 | 1 | Kim | 0 | | 9 | 1 | Brenda | 0 | | 10 | 1 | Darren | 0 | | 11 | 1 | Jonathan | 0 | +-------------+-------------+------------+-------------+ 10 rows selected (0.451 seconds) Thanks, Yash Sharma
