-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25409/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 10:15 p.m.)
Review request for drill, Alexander zarei, Norris Lee, and Parth Chandra.
Changes
-------
Rebased on master and tried a new approach based on comments. This patch
depends on DRILL-1511 to fix compling issue on Mac.
Here. we always ensure that in queryResultListener, the recordBatch is not
empty if DrillClientError object is NULL.
```cpp
QueryResultsListener(void* ctx, Drill::RecordBatch* b, Drill::DrillClientError*
err)
```
When the DrillClientError object is not NULL, it shows the status of the query.
In the case of receiving an QUERY_COMPLETED message, the status is
QRY_COMPLETED.
(Use the name DrillClientError may not appricaite here since it is not an
"error" anymore).
To implement this, this patch implements `handleTerminatedQryState` similar to
`handleQryError`.
Any opions on this approach?
Thanks,
Xiao
Bugs: DRILL-1305
https://issues.apache.org/jira/browse/DRILL-1305
Repository: drill-git
Description
-------
DRILL-1305: C++ Client. Consume QueryState message from the Drillbit.
Diffs (updated)
-----
contrib/native/client/example/querySubmitter.cpp
f886e819f43d21e07bb3df9956817783d69b98bd
contrib/native/client/src/clientlib/drillClientImpl.hpp
d690aad0e7ba5d006404036cb3c392d0b62a0ca9
contrib/native/client/src/clientlib/drillClientImpl.cpp
77795ed08367df58ae2ac43ef80ae16d5066ba91
contrib/native/client/src/clientlib/errmsgs.hpp
437335c560833875a3b50d0ee934f849e3a0af9e
contrib/native/client/src/clientlib/errmsgs.cpp
966cfc27be180bcaa3f46f437389b60fdaece7f5
contrib/native/client/src/include/drill/common.hpp
151d698b53fe0fa5f153b585448cb5536f2967be
Diff: https://reviews.apache.org/r/25409/diff/
Testing
-------
Thanks,
Xiao Meng
