> On nov. 18, 2014, 4:52 après-midi, Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java,
> > line 75
> > <https://reviews.apache.org/r/28173/diff/1/?file=767087#file767087line75>
> >
> > What is the purpose of this and why is it only get(0) than the entire
> > list?
>
> abdelhakim deneche wrote:
> I wondered the same actually, but I basically copy/pasted this code from
> TextFormatPlugin.
>
> Should I change it to take the entire list instead ?
I just tested the following format config:
"json": {
"type": "json",
"extensions": [
"json",
"log"
]
}
and I was able to query both .json and .log (with json data inside) fine.
- abdelhakim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28173/#review61932
-----------------------------------------------------------
On nov. 18, 2014, 4:48 après-midi, abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28173/
> -----------------------------------------------------------
>
> (Updated nov. 18, 2014, 4:48 après-midi)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-1545
> https://issues.apache.org/jira/browse/DRILL-1545
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> updated JSONFormatPlugin, adding an extensions array into JSONFormatConfig. I
> used TextFormatPlugin as a reference.
> Now the user can set the following format in Web UI:
> "json": {
> "type": "json",
> "extensions": [
> "json",
> "log"
> ]
> }
>
> The user can also write a separate config for json and log like this:
> "json": {
> "type": "json",
> "extensions": [
> "json"
> ]
> },
> "log": {
> "type": "json",
> "extensions": [
> "log"
> ]
> }
>
>
> Diffs
> -----
>
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java
> e1165a2
> exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 4a20bea
>
> Diff: https://reviews.apache.org/r/28173/diff/
>
>
> Testing
> -------
>
> created two copies of the same .json data file, one with .json extension and
> another with .log extension.
>
> updated "json" format like this:
>
> "json": {
> "type": "json",
> "extensions": [
> "json",
> "log"
> ]
> }
>
> once the change was done, I was able to query both files from sqlline.
>
>
> Thanks,
>
> abdelhakim deneche
>
>
