----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28340/#review62621 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java <https://reviews.apache.org/r/28340/#comment104693> kvgen should accept only maps as input. We should also check the MinorType here. exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1641Test.java <https://reviews.apache.org/r/28340/#comment104703> This test does not belong in the jdbc suite. Should be moved in part of the complex reader / writer. - Mehant Baid On Nov. 21, 2014, 6:57 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28340/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 6:57 p.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Changed from checking Java type of representation object to checking logical > type information. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java > 7f7a28c > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1641Test.java > PRE-CREATION > exec/jdbc/src/test/resources/bug1641_repeated_map_bug_case.json > PRE-CREATION > exec/jdbc/src/test/resources/bug1641_single_map_case.json PRE-CREATION > > Diff: https://reviews.apache.org/r/28340/diff/ > > > Testing > ------- > > Ran new fix-specific unit test; ran test suite. > > > Thanks, > > Daniel Barclay > >
