> On Nov. 25, 2014, 11:06 p.m., Hanifi Gunes wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java, > > line 72 > > <https://reviews.apache.org/r/28296/diff/1/?file=771483#file771483line72> > > > > My first impression is that Web UI in general sucks handling failures. > > With that, even though I understand that this patch regards to a particular > > scenario, I would be inclined to use native error handling mechanisms such > > like jackson/jersey/jetty for handling uncaught exceptions. > > > > As otherwise, try catch statement should surround the entire method > > body as, say, line 71 will still throw an IndexOutOfBounds when the result > > set is empty (see DRILL-1780).
I will start looking at better alternatives for the Web UI to handle failures. In the meantime, this patch can be considered as a workaround to help the user know what's going on. - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28296/#review63062 ----------------------------------------------------------- On Nov. 20, 2014, 8:10 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28296/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 8:10 p.m.) > > > Review request for drill. > > > Bugs: DRILL-1373 > https://issues.apache.org/jira/browse/DRILL-1373 > > > Repository: drill-git > > > Description > ------- > > The problem with the /query page is that it doesn't display enough > informations when an exception occurs while processing the query. The > proposed solution displays the exception message in a new error page. This > should help the user understand what's causing the error. > Of course, this patch assumes enough informations are available in the > exception message. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java > bea693c > exec/java-exec/src/main/resources/rest/query/error.ftl PRE-CREATION > > Diff: https://reviews.apache.org/r/28296/diff/ > > > Testing > ------- > > > Thanks, > > abdelhakim deneche > >
