I want to offer for a 2nd review my eri -> gldv3 conversion. I've updated it since my last posting (originally to osol-code), as follows:

   * lint clean (no lint tags anymore!)
   * passes cstyle -cPp
   * supports full-MTU vlan packets
   * link status logging is gone (will be done by Nemo per PSARC 2007/298)
   * converted to use the preferred DDI property functions
   * cleaned up unreference macros and code that was effectively #if 0'd
* trimmed out the debugging messages... no longer useful, and they obscured the code

The review is located at

   http://cr.opensolaris.org/~gdamore/nemo-eri

I've tested the driver with full size VLANs and IP instances on my SunBlade 100, and I'm happy with it.

I think all I need is to get my requisite 2-3 code reviewers, and its ready for putback. If anyone wants a binary ahead of time for additional testing, let me know, I'll be happy to supply one.

   -- Garrett

PS: My hme/qfe conversion is stalled for the moment, and I'm going to have to step away from it for a while to focus on other responsibilities. But as this work is already done, I'd like to get it committed to avoid having it fall thru the cracks.
_______________________________________________
driver-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/driver-discuss

Reply via email to