Steven Stallion wrote:
> Garrett,
>
> Changes look pretty straightforward to me, I did have one question though:
>
> hme.c:4035 - Is there a specific reason why the conditional specifically
> uses a != 0 rather than just 'hmep->hme_flags & HMESUSPENDED'? I thought
> this looked a little out of place since other conditionals in hme.c do not
> seem to follow this behavior.
>
Actually, I think a few other places I also used != 0. Although
compilers evaluate it the same way, I prefer to make comparison against
zero explicit. I thought at one point I'd even seen a style guide
recommending or requiring this.
Thanks.
-- Garrett
> Otherwise, +1.
>
> Steve
>
> On Fri, 07 Mar 2008 10:54:29 -0800, "Garrett D'Amore" <[EMAIL PROTECTED]>
> wrote:
>
>> I'm looking for reviewers for the following fixes to hme:
>>
>> 6612678 SUNWqfed postinstall complains about alias "SUNW,qfe" conflicts
>> 6619612 system panics when a qfe device instance tries to detach
>> 6672790 hmestart needs S/R check
>>
>> The webrev is located here: http://cr.opensolaris.org/~gdamore/hme/
>>
>> The changes are fairly straight-forward -- a whopping 62 lines, so it
>> shouldn't take long to review. An ancillary, but not separately
>> reported change, is that I cleaned up an unused kstat (newfree) that I
>> noticed.
>>
>> Testing of these changes has consisted of:
>>
>> * suspend/resume testing using sys-suspend on a SB100 with a QFE card
>> * testing included both while traffic was busy (in each direction
>> separately, and bidirectionally, and totally idle)
>> * verification of correct kstat counting
>> * detach testing with modload/modunload
>> * installation testing, including manually editing away the quotes
>> from "SUNW,qfe" in /etc/driver_aliases, rebooting, and then reinstalling
>>
>> I'll submit an RTI once I get two reviewers. It would be cool to get
>> this into snv_86, but I can wait until 87 if that is better.
>>
>> -- Garrett
>> _______________________________________________
>> driver-discuss mailing list
>> driver-discuss@opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/driver-discuss
>>
_______________________________________________
driver-discuss mailing list
driver-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/driver-discuss
