On Thu, 12 Jun 2008, Masa Murayama wrote: > Thank you very much for reviewing new sfe. > > I'll make the bug list which I found and fixed. As I'll take a little time, > I'll do that at this weekend. I have changed too many lines for struggling > vlan hang issue on sparc platforms.
I tried to point out that vlan was also going through changes, on the backend, so there was some moving-target syndrome. You probably saw that Steve Stallion also did a review with a list of items. I just wanted to point out that one or two of his might have been in regard to format and/or white space. I subscribe to allowing the author to maintain their code as they want, providing it meets cstyle/lint. I like to keep things similar and I could have reformatted something to be the same as another section/file. As an example, I know that when I put the #ident pragrma back in for SCCS, I like all the files to be the same. One or two of them I did add in an extra line. No biggie...you'll figure it out. I'll just wait for you to look over both Garrett's and Steve's lists. > Like patches in Linux, it agree to divide the bunch of changes into > simple changes, I think. Absolutely, but in this case it just wouldn't have worked, IMO, as there was just too much going on. Since 6655415 was the only CR open on this driver, that's why it is being used. I could create a new CR that would incorporate 6655415 in it, and adds a bunch of other stuff from your bug list. I'll ask jbeck if he'd like us to do that. -- Alan DuBoff - Solaris x86 IHV/OEM Group _______________________________________________ driver-discuss mailing list driver-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/driver-discuss
