yes, it was just for p-ata atapi device, and HDD was on ahci controller. But for disk ata mode, I also tested, most HDD will not change the DMA mode after S3 resume. So for your HDD, I'm not sure whether it was just a special case there.
As for pci-ide, I think it was already call pci_save_config_regs/ pci_restore_config_regs, did you mean besides that we still need to do a special saving/restoring the register related w/ DMA on pci configuring space? From my understanding all of them have been covered in pci_save_config_regs/pci_restore_config_regs functions. Juergen Keil wrote: > Do you know which device was affected by 6742621? I guess it was a > P-ATA ATAPI device, correct? > > What kind of HDD is used in the (Toshiba?) M8 from bug 6742621 ? > I guess it's a S-ATA HDD on the achi controller... > > > Yes, I think it would be better to save/restore the DMA mode for > both ATAPI and ATA disk devices. > > > But I suspect that there still could be problems with the DMA mode setup > for the pci-ide *controller*. Maybe we also need to save / restore some > DMA mode configuration registers from pci config space during s3 suspend / > resume, to make sure the *controller* uses the same mode after resume from > s3 sleep? > > > Ada Feng wrote: > > >> I seldom see this problem on disk, a lot of ATAPI device >> changed the DMA mode after resume. So if the disk has >> the same problem, we'd better to save/restore the DMA >> for disk also, like what have done for atapi device. >> >> Ada >> >> Juergen Keil wrote: >> >>> Hi, >>> >>> >>> One issue with using S3 suspend/resume on my Tecra S1 laptop is that >>> after a resume the first access to the p-ata hdd hangs the system. >>> >>> Just like 6742621, but I'm using nightly 2008-10-23 bits (post snv_101). >>> >>> >>> Apparently the problem is that UDMA 5 needs to be restored for the p-ata hdd >>> (fujitsu 80gb), but it isn't. >>> ... >>> > > _______________________________________________ driver-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/driver-discuss
