Folks:

Would really appreciate if you could review the code which implements
'POSSIBLE' MTU values feature. The CR for the same is "6680929 dladm
should print POSSIBLE values for properties like mtu by contacting the
driver".

Today, 'dladm show-linkprop -p mtu' output, the 'POSSIBLE' column
displays just '--'. With this fix, that column would be populated with
range of values (min - max) that can be used to set the 'mtu', of-course only if 'mtu' is writeable. In cases when MTU property cannot be set, one will see '--'; as for a 'read-only' MTU property, 'POSSIBLE' value is just the 'CURRENT' value and does not mean anything.

Sample output:

bash-3.2# dladm show-linkprop -p mtu
LINK         PROPERTY     PERM VALUE          DEFAULT        POSSIBLE
ixgb0        mtu          r-   1500           1500           --
e1000g0      mtu          rw   1500           1500           1500-9216
e1000g1      mtu          rw   1500           1500           1500-9216
e1000g2      mtu          rw   1510           1500           1500-9216
e1000g3      mtu          rw   1510           1500           1500-9216
aggr1        mtu          rw   1510           1500           1500-9216
stub1        mtu          rw   9000           1500           46-9000

The webrev can be found at:

http://cr.opensolaris.org/~girishmg/possible_mtu/

For folks within SWAN, workspace with cscope built can be found at:

/net/trigati.east/export/build/gm209912/possible_mtu

Would appreciate, if you could give comments by 22nd April.

thanks
~Girish

PS: As part of this fix, I had to change just bge, e1000g, nxge, nge, hxge, aggr and vnic. So, if driver authors for these drivers could review the fix that would be really great.

_______________________________________________
driver-discuss mailing list
driver-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/driver-discuss

Reply via email to