On Thursday, July 25, 2013 5:50 AM, Ian Abbott wrote:
> On 2013-07-24 19:47, H Hartley Sweeten wrote:
>> The comedi_subdevice pointer is not used in this function. Its simply
>> passed on to pcmuio_handle_intr_subdev(). That function then needs to
>> calculate the 'asic' associated with the subdevice. Just pass on the
>> 'asic' instead and let pcmuio_handle_intr_subdev() get the subdevice
>> from that.
>>
>> Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
>> Cc: Ian Abbott <abbo...@mev.co.uk>
>> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>
> In that case, it would make sense to rename the function to 
> pcmuio_handle_intr_asic().

Or just pcmuio_handle_pending_intr(), then the comment could also be
removed.

This could be a separate patch. But I can rebase the series it you wish.

Regards,
Hartley

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to