> > > -    cvmx_wait_usec(1000);
> > > +    mdelay(1);
> > 
> > why not udelay here?
> 
> It's long enough so that mdelay can be used. :)

sorry, I was meaning usleep_range :)

> > > -    cvmx_wait_usec(50000);
> > > +    mdelay(50);
> > 
> > and why not msleep here?
> 
> cvmx_usb_enable() is called holding a spinlock with interrupts disabled.
> We cannot sleep here.

Arrgghhh! OK, makes sense then.

Thanks,
Andi
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to