On 2013-10-01 01:49, H Hartley Sweeten wrote:
Cleanup another comedi driver.
This series depends on:
staging: comedi: ni_at_ao: fix namespace clash of 'RSI' define
Patch 19/21 changes the names that are used to attach to the driver.
If Ian has issues with this it can be dropped.
The previous names look like a typo, so may as well fix them.
Patch 20/21 changes the analog output range support. Again, if Ian
has issues with this it can be dropped. Patch 21/21 will need to be
rebased if 20/21 is not applied (or I can rebase this series and
not have the typo...).
I have technical issues with patch 20, but the concept is fine. Patch
20 needs some unneeded (and slightly dubious) code trimming out, and
patch 21 would need rebasing.
H Hartley Sweeten (21):
staging: comedi: ni_at_ao: remove ATAO_SIZE define
staging: comedi: ni_at_ao: tidy up the register map defines
staging: comedi: ni_at_ao: tidy up digital i/o register defines
staging: comedi: ni_at_ao: tidy up CFG1 register defines
staging: comedi: ni_at_ao: tidy up the STATUS register defines
staging: comedi: ni_at_ao: remove 'cfg2' from private data
staging: comedi: ni_at_ao: tidy up the calibration subdevice
staging: comedi: ni_at_ao: tidy up the CFG3 register defines
staging: comedi: ni_at_ao: use 8253.h helpers
staging: comedi: ni_at_ao: rename the rest of the register map
staging: comedi: ni_at_ao: move the boardinfo declaration
staging: comedi: ni_at_ao: move the atao_reset() function
staging: comedi: ni_at_ao: introduce atao_select_reg_group()
staging: comedi: ni_at_ao: tidy up atao_ao_winsn()
staging: comedi: ni_at_ao: tidy up atao_ao_rinsn()
staging: comedi: ni_at_ao: tidy up atao_attach()
staging: comedi: ni_at_ao: tidy up multi-line comments
staging: comedi: ni_at_ao: change MODULE_DESCRIPTION
staging: comedi: ni_at_ao: fix board names
staging: comedi: ni_at_ao: fix analog output ranges
staging: comedi: ni_at_ao: fix typo for DAC2S bit in the CFG2 register
drivers/staging/comedi/drivers/ni_at_ao.c | 557 ++++++++++++++++--------------
1 file changed, 293 insertions(+), 264 deletions(-)
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
for patches 01 to 19 inclusive.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
