These functions can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.

Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/comedi/drivers/pcl818.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl818.c 
b/drivers/staging/comedi/drivers/pcl818.c
index 3dac1dd..5fc4708 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -700,7 +700,7 @@ static irqreturn_t interrupt_pcl818(int irq, void *d)
 
        outb(0, dev->iobase + PCL818_CLRINT);   /* clear INT request */
 
-       if (!dev->irq || !devpriv->irq_blocked || !devpriv->ai_mode) {
+       if (!devpriv->irq_blocked || !devpriv->ai_mode) {
                comedi_error(dev, "bad IRQ!");
                return IRQ_NONE;
        }
@@ -762,10 +762,6 @@ static int pcl818_ai_cmd_mode(int mode, struct 
comedi_device *dev,
        unsigned int seglen;
 
        dev_dbg(dev->class_dev, "pcl818_ai_cmd_mode()\n");
-       if (!dev->irq) {
-               comedi_error(dev, "IRQ not defined!");
-               return -EINVAL;
-       }
 
        if (devpriv->irq_blocked)
                return -EBUSY;
-- 
1.8.4.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to