> -----Original Message----- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, January 09, 2014 4:04 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service > > On Wed, Jan 08, K. Y. Srinivasan wrote: > > > +++ b/tools/hv/hv_fcopy_daemon.c > > > + len = pread(fcopy_fd, buffer, (4096 * 2), 0); > > + > > + if (len <= 0) { > > + syslog(LOG_ERR, "Read error: %s\n", strerror(errno)); > > + continue; > > This could flood syslog. I think the error should be logged just once. > Maybe like this: > > if (len <=0) { > if (!error) { > syslog(...); > error = HV_ERROR_NOT_SUPPORTED; > } > continue; > } > > > + } > > + in_msg = (struct hv_fcopy_hdr *)buffer; > > + > > + switch (in_msg->operation) { > > + case START_FILE_COPY: > > + error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);
Will do. K. Y > > Olaf _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
