[PATCH 19/48] staging: comedi: dt2811: use comedi_timeout()

[H Hartley Sweeten]

Use comedi_timeout() to wait for the analog input end-of-conversion.

Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/comedi/drivers/dt2811.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dt2811.c 
b/drivers/staging/comedi/drivers/dt2811.c
index 4271903..ba7c2ba 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -224,23 +224,32 @@ static const struct comedi_lrange *dac_range_types[] = {
        &range_unipolar5
 };
 
-#define DT2811_TIMEOUT 5
+static int dt2811_ai_eoc(struct comedi_device *dev,
+                        struct comedi_subdevice *s,
+                        struct comedi_insn *insn,
+                        unsigned long context)
+{
+       unsigned int status;
+
+       status = inb(dev->iobase + DT2811_ADCSR);
+       if ((status & DT2811_ADBUSY) == 0)
+               return 0;
+       return -EBUSY;
+}
 
 static int dt2811_ai_insn(struct comedi_device *dev, struct comedi_subdevice 
*s,
                          struct comedi_insn *insn, unsigned int *data)
 {
        int chan = CR_CHAN(insn->chanspec);
-       int timeout = DT2811_TIMEOUT;
+       int ret;
        int i;
 
        for (i = 0; i < insn->n; i++) {
                outb(chan, dev->iobase + DT2811_ADGCR);
 
-               while (timeout
-                      && inb(dev->iobase + DT2811_ADCSR) & DT2811_ADBUSY)
-                       timeout--;
-               if (!timeout)
-                       return -ETIME;
+               ret = comedi_timeout(dev, s, insn, dt2811_ai_eoc, 0);
+               if (ret)
+                       return ret;
 
                data[i] = inb(dev->iobase + DT2811_ADDATLO);
                data[i] |= inb(dev->iobase + DT2811_ADDATHI) << 8;
-- 
1.8.5.2

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel