On 06/03/14 06:57, Fred Akers wrote:
This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list

Signed-off-by: Fred Akers <kni...@botops.net>
---
  drivers/staging/comedi/range.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index c4bb13b..b684954 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -143,10 +143,6 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int 
n,
        unsigned int chanspec;
        int chan, range_len, i;

-       if (!s->range_table && !s->range_table_list) {
-               dev_err(dev->class_dev, "(bug) no range type list!\n");
-               return -EINVAL;
-       }
        for (i = 0; i < n; i++) {
                chanspec = chanlist[i];
                chan = CR_CHAN(chanspec);


Reviewed-by: Ian Abbott <abbo...@mev.co.uk>

(Further down this `for` loop, the NULL-ness test on `s->range_table_list` is also technically redundant, but I think the code is clearer with the check left in, and is safer in a defensive way.)

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to