From: "K. Y. Srinivasan" <k...@microsoft.com> Date: Thu, 6 Mar 2014 03:13:09 -0800
> +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4, > + bool *is_tcp, bool *is_udp, u32 *trans_off) > +{ Returning so many values like this is awkward, at best. Why not return a well defined bitmask: #define TRANSPORT_INFO_SUCCESS 0x00000001 #define TRANSPORT_INFO_TCP 0x00000002 #define TRANSPORT_INFO_UDP 0x00000004 Then the only value you have to return by reference is trans_off. _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel