[PATCH 01/02] linux-next: staging: gdm72xx: coding style fixes

[Alexandr Terekhov]

Fix:
- unnecessary whitespace before a quoted newline
- using `time_before` instread of comparisons of jiffies
- enclosing macro in parenthesis
- line over 80 characters

Signed-off-by: Alexandr Terekhov  <a.terek...@gmail.com>

diff --git a/drivers/staging/gdm72xx/gdm_qos.c 
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..245109e 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -377,7 +377,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int 
size)
        index = get_csr(qcb, SFID, 1);
        if (index == -1) {
                netdev_err(nic->netdev,
-                          "QoS ERROR: csr Update Error / Wrong index (%d) \n",
+                          "QoS ERROR: csr Update Error / Wrong index (%d)\n",
                           index);
                return;
        }
diff --git a/drivers/staging/gdm72xx/gdm_usb.c 
b/drivers/staging/gdm72xx/gdm_usb.c
index 20539d8..ac8616d 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -730,7 +730,7 @@ static int k_mode_thread(void *arg)
                        spin_unlock_irqrestore(&k_lock, flags2);
 
                        expire = jiffies + K_WAIT_TIME;
-                       while (jiffies < expire)
+                       while (time_before(jiffies, expire))
                                schedule_timeout(K_WAIT_TIME);
 
                        spin_lock_irqsave(&rx->lock, flags);
@@ -759,8 +759,7 @@ static int k_mode_thread(void *arg)
                        spin_lock_irqsave(&k_lock, flags2);
                }
                wait_event_interruptible_lock_irq(k_wait,
-                                                 !list_empty(&k_list) || 
k_mode_stop,
-                                                 k_lock);
+                       !list_empty(&k_list) || k_mode_stop, k_lock);
                spin_unlock_irqrestore(&k_lock, flags2);
        }
        return 0;
diff --git a/drivers/staging/gdm72xx/usb_ids.h 
b/drivers/staging/gdm72xx/usb_ids.h
index b34616b..b215f9a 100644
--- a/drivers/staging/gdm72xx/usb_ids.h
+++ b/drivers/staging/gdm72xx/usb_ids.h
@@ -32,8 +32,8 @@
 #define BL_PID_MASK                    0xffc0
 
 #define USB_DEVICE_BOOTLOADER(vid, pid)        \
-       {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)},    \
-       {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)}
+       ({USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)},   \
+       {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)})
 
 #define USB_DEVICE_CDC_DATA(vid, pid)  \
        {USB_DEVICE_INTF((vid), (pid), USB_CLASS_CDC_DATA)}

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel