On Sun, Aug 16, 2020 at 11:57:17AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:06 +0800, Coiby Xu wrote:
The related code are not necessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
I would suggest to add the drgn script from the cover letter to
Documentation/networking/device_drivers/qlogic/
Thank you for this suggestion! I planned to send a pull request to
https://github.com/osandov/drgn. This is a better idea.
I would also suggest to submit a separate patch now which fixes the
build breakage reported in <20200629053004.GA6165@f3> while you work on
removing that code.
I'll send a single patch to fix that issue before preparing for v1
of this work.
Signed-off-by: Coiby Xu <coiby...@gmail.com>
---
drivers/staging/qlge/qlge.h | 82 ----
drivers/staging/qlge/qlge_dbg.c | 672 ----------------------------
drivers/staging/qlge/qlge_ethtool.c | 1 -
drivers/staging/qlge/qlge_main.c | 6 -
4 files changed, 761 deletions(-)
[...]
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 058889687907..368394123d16 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1326,675 +1326,3 @@ void ql_mpi_core_to_log(struct work_struct *work)
sizeof(*qdev->mpi_coredump), false);
}
-#ifdef QL_REG_DUMP
-static void ql_dump_intr_states(struct ql_adapter *qdev)
-{
[...]
- }
-}
-#endif
This leaves a stray newline at the end of the file and also does not
apply over latest staging.
I will fix it in v1. Thank you for reviewing this patch!
--
Best regards,
Coiby
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
