Use the adis managed device functions to setup the buffer and the trigger.
The ultimate goal will be to completely drop the non devm version from
the lib.

Signed-off-by: Nuno Sá <nuno...@analog.com>
---
 drivers/iio/imu/adis16400.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
index 1ebe3e50d3e6..7bf4b0065022 100644
--- a/drivers/iio/imu/adis16400.c
+++ b/drivers/iio/imu/adis16400.c
@@ -1201,37 +1201,30 @@ static int adis16400_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = adis_setup_buffer_and_trigger(&st->adis, indio_dev,
-                       adis16400_trigger_handler);
+       ret = devm_adis_setup_buffer_and_trigger(&st->adis, indio_dev, 
adis16400_trigger_handler);
        if (ret)
                return ret;
 
        /* Get the device into a sane initial state */
        ret = adis16400_initial_setup(indio_dev);
        if (ret)
-               goto error_cleanup_buffer;
+               return ret;
+
        ret = iio_device_register(indio_dev);
        if (ret)
-               goto error_cleanup_buffer;
+               return ret;
 
        adis16400_debugfs_init(indio_dev);
        return 0;
-
-error_cleanup_buffer:
-       adis_cleanup_buffer_and_trigger(&st->adis, indio_dev);
-       return ret;
 }
 
 static int adis16400_remove(struct spi_device *spi)
 {
        struct iio_dev *indio_dev = spi_get_drvdata(spi);
-       struct adis16400_state *st = iio_priv(indio_dev);
 
        iio_device_unregister(indio_dev);
        adis16400_stop_device(indio_dev);
 
-       adis_cleanup_buffer_and_trigger(&st->adis, indio_dev);
-
        return 0;
 }
 
-- 
2.28.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to