Am 20.05.2014 13:41, schrieb Dan Carpenter: > Those concerns are valid but the code was like that in the original so > we should merge this patch as is and hope some volunteer will fix things > up in a follow on patch. > > Fixing them in this patch would be a mistake anyway because of the one > thing per patch rule. >
I see this as a bordercase, the patch from Peter is correct in the context of removing useless return variables. I question the whole function in the hope that the maintainer will decide that the function can go completely. re, wh _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
