On Tue, May 20, 2014 at 05:12:45PM +0200, Matthias Beyer wrote:
> This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
> handling to shorten the bcm_char_ioctl_nvm_rw() function.
>
This one is grand. I wish you had put the function ahead so we don't
have to have the forward declaration. The indenting was messed up in
the original code.
> + if ((Adapter->IdleMode == TRUE) ||
> + (Adapter->bShutStatus == TRUE) ||
> + (Adapter->bPreparingForLowPowerMode == TRUE)) {
This should be:
if (Adapter->IdleMode == TRUE ||
Adapter->bShutStatus == TRUE ||
Adapter->bPreparingForLowPowerMode == TRUE) {
But that was like that in the original.
Reviewed-by: Dan Carpenter <dan.carpen...@oracle.com>
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
