Sorry, I meant that "return directly" applied for all the new gotos.
Don't do this:

        rc = -ENXIO;
        goto exit;

...
exit:
        return rc;

It just makes the code harder to read.  Do this:

        return -ENXIO;

without all the goto leap hop jumping around.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to