From: Haiyang Zhang <haiya...@microsoft.com>
Date: Wed, 13 Aug 2014 18:03:44 +0000

> When the buffer is too small for a packet from VMBus, a bigger buffer will be
> allocated in netvsc_channel_cb() and retry reading the packet from VMBus.
> Increasing this buffer size will reduce the retry overhead.
> 
> Signed-off-by: Haiyang Zhang <haiya...@microsoft.com>
> Reviewed-by: Dexuan Cui <de...@microsoft.com>
...
> -     net_device = kzalloc(sizeof(struct netvsc_device), GFP_KERNEL);
> +     net_device = vzalloc(sizeof(*net_device));

This isn't what I suggested that you do.

I said that the buffer inside of netvsc_device should be made an
indirect pointer and thus allocated seperately.

Thus you're still kzalloc() net_device, but net_device->cb_buffer
becomes "unsigned char *" and another allocation is made for it.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to