Hello Mark Einon,
The patch c2ebf58ba089: "staging: et131x: Implement NAPI support"
from Aug 21, 2014, leads to the following static checker warning:
drivers/staging/et131x/et131x.c:4004 et131x_isr()
warn: we tested 'status' before and it was 'true'
drivers/staging/et131x/et131x.c
3853 status &= ~(ET_INTR_TXDMA_ISR | ET_INTR_RXDMA_XFR_DONE);
3854
3855 if (!status)
3856 goto out;
3857
[ snip ]
4003
4004 if (!status) {
This is dead code.
4005 /* This interrupt has in some way been "handled" by
4006 * the ISR. Either it was a spurious Rx interrupt, or
4007 * it was a Tx interrupt that has been filtered by
4008 * the ISR.
4009 */
4010 et131x_enable_interrupts(adapter);
4011 }
4012
4013 out:
4014 return IRQ_RETVAL(handled);
4015 }
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
