On Tue, 2014-10-07 at 16:48 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by 
> checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c 
> b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -414,19 +414,19 @@ u8 r8712_efuse_pg_packet_write(struct _adapter 
> *padapter, const u8 offset,
[]
> +             /* call rescue procedure */
> +             if (fix_header(padapter, efuse_data, efuse_addr) ==
> +                 false)
> +                     return false; /* rescue fail */

Probably better as:

                if (!fix_header(padapter, efuse_data, efuse_addr))
                        return false;   /* rescue fail */



_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to