-----Original Message-----
From: Joe Perches [mailto:j...@perches.com]
Sent: Wednesday, November 05, 2014 10:46 PM
To: Sharma, Sanjeev
Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com;
gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org;
de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by
checkpatch.
On Wed, 2014-11-05 at 17:05 +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes Error reported by
> checkpatch.
Please run your patches through checkpatch before sending them.
In this patch I am fixing error reported by check patch since Error has higher
priority.
WARNING: suspect code indent for conditional statements (24, 24)
#178: FILE: drivers/staging/rtl8723au/core/rtw_cmd.c:1025:
+ if (check_fwstate(pmlmepriv, _FW_LINKED))
LPS_Leave23a(padapter);
Also, there are a couple of different things you changing here.
This should be 2 separate patches.
Ok I will come up with 2 patch separately.
One to use the temporary for:
+ struct rt_link_detect *ldi = &pmlmepriv->LinkDetectInfo;
(and that bit has a defect here:
+ } else {
LPS_Leave23a(padapter);
+ }
where the indentation for the last close brace is wrong)
and another for the whitespace only changes
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
