> static BOOL
> -Initialize_incoming_thread(void)
> +initialize_incoming_thread(void)
> {
> if (incoming_started)
> return TRUE;
> if (!uisthread_start(&incoming_ti,
> &process_incoming, NULL, "dev_incoming")) {
> - LOGERR("uisthread_start Initialize_incoming_thread
> ****FAILED");
> + LOGERR("uisthread_start initialize_incoming_thread
> ****FAILED");
Not related to the patch, but improving the error message with a
return code saying
+ LOGERR("failed to start the thread, reason = %d\n",
ret);
You might consider using dev_ routines for logging than the driver wrappers.
> return FALSE;
> }
> incoming_started = TRUE;
> @@ -1373,7 +1373,7 @@ uislib_enable_channel_interrupts(u32 bus_no, u32 dev_no,
> return;
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
