On 01/02/2015 12:17 PM, Larry Finger wrote:
The driver allocates memory to store the firmware image; however, that
memory is never released. The kmemleak facility was used to find this
error.

Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>
---
  drivers/staging/rtl8188eu/hal/fw.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8188eu/hal/fw.c 
b/drivers/staging/rtl8188eu/hal/fw.c
index 3b28754..a5b7fc4 100644
--- a/drivers/staging/rtl8188eu/hal/fw.c
+++ b/drivers/staging/rtl8188eu/hal/fw.c
@@ -231,6 +231,7 @@ int rtl88eu_download_fw(struct adapter *adapt)
        _rtl88e_enable_fw_download(adapt, false);

        err = _rtl88e_fw_free_to_go(adapt);
+       kfree(pfwdata);

        return err;
  }

Greg,

Please drop this patch. Unfortunately, further testing showed that the kfree() call is in the wrong place. I will send V2 shortly.

Thanks,

Larry


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to