On Mon, Mar 09, 2015 at 07:42:53AM +0000, Lad, Prabhakar wrote:
> On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
> <sudipm.mukher...@gmail.com> wrote:
> >
> >
> > this patch will give checkpatch warnings about use of printk.
> > this patch was mainly to fix the build warnings. printk will be
> > converted to pr_* and dev_* in a later patch.
> >
> > + printk("lynxfb mmap pgoff: %lx\n", vma->vm_pgoff);
> > + printk("lynxfb mmap off 1: %lx\n", off);
> >
> wouldn't it makes sense to change printk to some pr_*() ?
yes, i could have. But usually Greg does not accept patches which is doing more
than one type of change. That is why I mentioned in the comments that this will
be converted to pr_* and dev_* in a later patch.
regards
sudip
>
> Cheers,
> --Prabhakar Lad
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
