On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato <mattew8...@gmail.com> > > The bitmask should be used on msignals since the signals variable is not > used anywhere in the function. >
You're probably right. I would really like to get Mark's Ack on this though becuase it's sort of a guess and not tested. regards, dan carpenter > Signed-off-by: Matteo Semenzato <mattew8...@gmail.com> > --- > drivers/staging/dgnc/dgnc_cls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index bedc522..29c6316 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, > unsigned char signals) > * Scrub off lower bits. They signify delta's, which I don't > * care about > */ > - signals &= 0xf0; > + msignals &= 0xf0; > > spin_lock_irqsave(&ch->ch_lock, flags); > if (msignals & UART_MSR_DCD) > -- > 2.3.1 > > _______________________________________________ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
