Hi,

On Wed, Mar 18, 2015 at 10:18:29PM +0530, Amitoj Kaur Chawla wrote:
> This file contained a lot of warnings of line of over 80 characters
> and that the code needs to be refactored due to nested if else
> conditions.
> 
> The file was accordingly edited to remove some of the warnings.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c 
> b/drivers/staging/octeon-usb/octeon-hcd.c
> index c8df0c3..e944292 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2920,11 +2920,11 @@ static int __cvmx_usb_poll_channel(struct 
> cvmx_usb_state *usb, int channel)
>                                        */
>                                       if (!usbc_hcchar.s.epdir) {
>                                               if (buffer_space_left < 
> pipe->max_packet)
> -                                                     
> transaction->actual_bytes +=
> -                                                             
> buffer_space_left;
> +                                                 transaction->actual_bytes +=
> +                                                           buffer_space_left;
>                                               else
> -                                                     
> transaction->actual_bytes +=
> -                                                             
> pipe->max_packet;
> +                                                 transaction->actual_bytes +=
> +                                                            pipe->max_packet;

You could reduce deep indentation here by moving the whole ACK bit
handling into a separate function.

A.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to