From: gre...@linuxfoundation.org <gre...@linuxfoundation.org>
Sent: Thursday, April 30, 2015 3:05 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr; dan.carpen...@oracle.com; 
larry.fin...@lwfinger.net; florian.c.schilha...@googlemail.com; Babu, 
Viswanathan (V.)
Subject: Re: [PATCH] staging: rtl8712: return error directly

On Thu, Apr 30, 2015 at 08:23:08AM +0000, Gujulan Elango, Hari Prasath (H.) 
wrote:
> Signed-off-by: Hari Prasath Gujulan Elango <hguju...@visteon.com>
>
> return error directly to avoid unwanted branching where no cleanup
> is done.Also removes the ret variable.

signed-off-by goes below the description, not above it.

Please fix up and resend.

----

I have sent the v2 patch.
regards
hari
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to