If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
cfb_imageblit(), not return directly. Otherwise it can't display the
boot logo.

Cc: Teddy Wang <teddy.w...@siliconmotion.com>
Acked-by: Sudip Mukherjee <sudipm.mukher...@gmail.com>
Signed-off-by: Huacai Chen <che...@lemote.com>
---
 V2: Coding style ajustment.
 V3: Add TODO comments.
 V4: Rebase on latest code.

 drivers/staging/sm750fb/TODO    |    1 +
 drivers/staging/sm750fb/sm750.c |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO
index bc16172..f8698498 100644
--- a/drivers/staging/sm750fb/TODO
+++ b/drivers/staging/sm750fb/TODO
@@ -2,6 +2,7 @@ TODO:
 - lots of checkpatch cleanup
 - use kernel coding style
 - refine the code and remove unused code
+- Implement hardware acceleration for imageblit if image->depth > 1
 - check on hardware effects of removal of USE_HW_I2C and USE_DVICHIP (these two
        are supposed to be sample code which is given here if someone wants to
        use those functionalities)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 3c7ea95..6f78de3 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -279,7 +279,10 @@ static void lynxfb_ops_imageblit(struct fb_info *info,
                }
                goto _do_work;
        }
+       /* TODO: Implement hardware acceleration for image->depth > 1 */
+       cfb_imageblit(info, image);
        return;
+
 _do_work:
        /*
         * If not use spin_lock, system will die if user load driver
-- 
1.7.7.3


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to