On 2015-06-18 08:51, Joe Perches wrote:
> On Thu, 2015-06-18 at 15:50 +0200, Peter Karlsson wrote:
> > Fix checkpatch warnings about lines over 80 characters.
> []
> > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> > b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> []
> > @@ -414,12 +414,20 @@ static long ft1000_ioctl(struct file *file, unsigned
> > int command,
> > unsigned long flags;
> > struct IOCTL_GET_VER get_ver_data;
> > struct IOCTL_GET_DSP_STAT get_stat_data;
> > - u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00,
> > 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64,
> > - 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a,
> > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02,
> > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12,
> > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > - 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08,
> > 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00,
> > - 0x00, 0x01, 0x00, 0x00};
> > + u8 ConnectionMsg[] = {
> > + 0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
>
> 7 bytes per line is unusual.
> 8 or 10 is more common.
You are right. I guess i should redo the patches. Frans Klaver also pointed
out that four commits have the same commit message, which is not good.
Peter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
