Yes they are all intentional, it was a way to make the logic more obvious (argument on the right is bitmask).
Henri On 07/15/2015 01:08 PM, Julia Lawall wrote: > TThese look intentional, but maybe double check the first one, with the > code shown in this message. > > julia > > On Wed, 15 Jul 2015, kbuild test robot wrote: > >> TO: Henri Chain <henri.ch...@eleves.ec-nantes.fr> >> CC: "Greg Kroah-Hartman" <gre...@linuxfoundation.org> >> CC: de...@driverdev.osuosl.org >> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> staging-testing >> head: bd1fb5388da0a37c053649ec4aa8e588ef39f958 >> commit: a1560f9bec8b9275a751bd39a1db791d2c73d6e5 [134/169] Staging: fbtft: >> Add support for the Ultrachip UC1611 LCD controller >> :::::: branch date: 2 hours ago >> :::::: commit date: 3 hours ago >> >>>> drivers/staging/fbtft/fb_uc1611.c:105:24-28: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:177:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:178:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:191:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:195:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:203:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:204:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:208:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:209:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:217:6-9: duplicated argument to & or | >> drivers/staging/fbtft/fb_uc1611.c:222:6-9: duplicated argument to & or | >> >> git remote add staging >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> git remote update staging >> git checkout a1560f9bec8b9275a751bd39a1db791d2c73d6e5 >> vim +105 drivers/staging/fbtft/fb_uc1611.c >> >> a1560f9b Henri Chain 2015-07-14 89 write_reg(par, 0xE8 | (ratio & >> 0x03)); >> a1560f9b Henri Chain 2015-07-14 90 >> a1560f9b Henri Chain 2015-07-14 91 /* Set bias gain and >> potentiometer */ >> a1560f9b Henri Chain 2015-07-14 92 write_reg(par, 0x81); >> a1560f9b Henri Chain 2015-07-14 93 write_reg(par, (gain & 0x03) << >> 6 | (pot & 0x3F)); >> a1560f9b Henri Chain 2015-07-14 94 >> a1560f9b Henri Chain 2015-07-14 95 /* Set temperature compensation >> */ >> a1560f9b Henri Chain 2015-07-14 96 write_reg(par, 0x24 | (temp & >> 0x03)); >> a1560f9b Henri Chain 2015-07-14 97 >> a1560f9b Henri Chain 2015-07-14 98 /* Set panel loading */ >> a1560f9b Henri Chain 2015-07-14 99 write_reg(par, 0x28 | (load & >> 0x03)); >> a1560f9b Henri Chain 2015-07-14 100 >> a1560f9b Henri Chain 2015-07-14 101 /* Set pump control */ >> a1560f9b Henri Chain 2015-07-14 102 write_reg(par, 0x2C | (pump & >> 0x03)); >> a1560f9b Henri Chain 2015-07-14 103 >> a1560f9b Henri Chain 2015-07-14 104 /* Set inverse display */ >> a1560f9b Henri Chain 2015-07-14 @105 write_reg(par, 0xA6 | (0x01 & >> 0x01)); >> a1560f9b Henri Chain 2015-07-14 106 >> a1560f9b Henri Chain 2015-07-14 107 /* Set 4-bit grayscale mode */ >> a1560f9b Henri Chain 2015-07-14 108 write_reg(par, 0xD0 | (0x02 & >> 0x03)); >> a1560f9b Henri Chain 2015-07-14 109 >> a1560f9b Henri Chain 2015-07-14 110 /* Set Display enable */ >> a1560f9b Henri Chain 2015-07-14 111 write_reg(par, 0xA8 | 0x07); >> a1560f9b Henri Chain 2015-07-14 112 >> a1560f9b Henri Chain 2015-07-14 113 return 0; >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
