On 14/08/15 09:54, Dan Carpenter wrote:
This was supposed to bitwise AND but there is a typo.Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c index 5aa1780..15a5320 100644 --- a/drivers/staging/comedi/drivers/me4000.c +++ b/drivers/staging/comedi/drivers/me4000.c @@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev, entry = chan | ME4000_AI_LIST_RANGE(range); if (aref == AREF_DIFF) { - if (!(s->subdev_flags && SDF_DIFF)) { + if (!(s->subdev_flags & SDF_DIFF)) { dev_err(dev->class_dev, "Differential inputs are not available\n"); return -EINVAL; @@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev, } if (aref == AREF_DIFF) { - if (!(s->subdev_flags && SDF_DIFF)) { + if (!(s->subdev_flags & SDF_DIFF)) { dev_err(dev->class_dev, "Differential inputs are not available\n"); return -EINVAL;
Thanks for catching that. Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
