On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
This macro has no added value, it makes uselessly code more verbose.

Nitpick here. It should be "uselessly makes".

Larry


Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
  drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 31 ++++++++++++------------
  1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h 
b/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
index 76deaf16e45e..cc3857dbfe09 100644
--- a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
@@ -627,26 +627,25 @@ u8 set_csa_hdl(struct adapter *padapter, unsigned char 
*pbuf);
  u8 tdls_hdl(struct adapter *padapter, unsigned char *pbuf);

  #define GEN_DRV_CMD_HANDLER(size, cmd)        {size, &cmd ## _hdl},
-#define GEN_MLME_EXT_HANDLER(size, cmd)        {size, cmd},

  #ifdef _RTW_CMD_C_

  static struct cmd_hdl wlancmds[] = {
-       GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), join_cmd_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct disconnect_parm), disconnect_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), createbss_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct setopmode_parm), setopmode_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct sitesurvey_parm), sitesurvey_cmd_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct setauth_parm), setauth_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct setkey_parm), setkey_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct set_stakey_parm), set_stakey_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct set_assocsta_parm), NULL)
-       GEN_MLME_EXT_HANDLER(sizeof(struct addBaReq_parm), add_ba_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct set_ch_parm), set_ch_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), tx_beacon_hdl)
-       GEN_MLME_EXT_HANDLER(0, mlme_evt_hdl)
-       GEN_MLME_EXT_HANDLER(0, rtw_drvextra_cmd_hdl)
-       GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param), 
set_chplan_hdl)
+       {sizeof(struct wlan_bssid_ex), join_cmd_hdl},
+       {sizeof(struct disconnect_parm), disconnect_hdl},
+       {sizeof(struct wlan_bssid_ex), createbss_hdl},
+       {sizeof(struct setopmode_parm), setopmode_hdl},
+       {sizeof(struct sitesurvey_parm), sitesurvey_cmd_hdl},
+       {sizeof(struct setauth_parm), setauth_hdl},
+       {sizeof(struct setkey_parm), setkey_hdl},
+       {sizeof(struct set_stakey_parm), set_stakey_hdl},
+       {sizeof(struct set_assocsta_parm), NULL},
+       {sizeof(struct addBaReq_parm), add_ba_hdl},
+       {sizeof(struct set_ch_parm), set_ch_hdl},
+       {sizeof(struct wlan_bssid_ex), tx_beacon_hdl},
+       {0, mlme_evt_hdl},
+       {0, rtw_drvextra_cmd_hdl},
+       {sizeof(struct SetChannelPlan_param), set_chplan_hdl},
  };

  #endif


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to