On 09/18/2015 03:19 PM, BryanSPaul wrote:
replaced memcpy functions with ether_addr_copy
Signed-off-by: Bryan Paul <bryan.p...@yahoo.com>
You seem not to be aware that ether_addr_copy() requires alignment of the
operands. Until you demonstrate that you have investigated such alignment,
NACK
Larry
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 54eb765..1bd3b36 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -460,7 +460,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct
wlan_network *pnetwork)
/* the driver just has the bssid information for PMKIDList searching.
*/
if (!pmlmepriv->assoc_by_bssid)
- memcpy(&pmlmepriv->assoc_bssid[0],
&pnetwork->network.MacAddress[0], ETH_ALEN);
+ ether_addr_copy(&pmlmepriv->assoc_bssid[0],
&pnetwork->network.MacAddress[0]);
psecnetwork->IELength = rtw_restruct_sec_ie(padapter, &pnetwork->network.IEs[0],
&psecnetwork->IEs[0], pnetwork->network.IELength);
@@ -731,7 +731,7 @@ u8 rtw_addbareq_cmd(struct adapter *padapter, u8 tid, u8
*addr)
}
paddbareq_parm->tid = tid;
- memcpy(paddbareq_parm->addr, addr, ETH_ALEN);
+ ether_addr_copy(paddareq_parm->addr);
init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm,
GEN_CMD_CODE(_AddBAReq));
--
2.4.6
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
