> -----Original Message----- > From: Florian Westphal [mailto:f...@strlen.de] > Sent: Tuesday, November 24, 2015 12:56 AM > To: KY Srinivasan <k...@microsoft.com> > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head > room in the skb > > K. Y. Srinivasan <k...@microsoft.com> wrote: > > The rndis header is 116 bytes big and can be placed in the default > > head room that will be available in the skb. Since the netvsc packet > > is less than 48 bytes, we can use the skb control buffer > > for the netvsc packet. With these changes we don't need to > > ask for additional head room. > > Minor nit: could you add a BUILD_BUG_ON test for this? Something like > > BUILD_BUG_ON(sizeof(struct hv_netvsc_packet) > FIELD_SIZEOF(struct > sk_buff, cb));
Good point; will add this check. Thanks, K. Y _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
