On 23/03/16 22:36, H Hartley Sweeten wrote:
The NI TIO support is split into 2 driver modules, ni_tio and ni_tiocmd. Theses drivers, and the headers have a lot of checkpatch.pl issues.drivers/staging/comedi/drivers/ni_tio_internal.h total: 0 errors, 13 warnings, 61 checks, 245 lines checked drivers/staging/comedi/drivers/ni_tio.h total: 0 errors, 10 warnings, 3 checks, 154 lines checked drivers/staging/comedi/drivers/ni_tio.c total: 0 errors, 101 warnings, 15 checks, 1436 lines checked drivers/staging/comedi/drivers/ni_tiocmd.c total: 0 errors, 19 warnings, 1 checks, 478 lines checked This includes 15: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() This series fixes all the checkpatch.pl issues. H Hartley Sweeten (28): staging: comedi: ni_tio_internal.h: tidy up bit defines staging: comedi: ni_tio_internal.h: fix block comment issues staging: comedi: ni_tio: fix ni_tio_set_gate_src() params/vars staging: comedi: ni_tio: fix ni_tio_arm() params/vars staging: comedi: ni_tio: export and fix ni_tio_get_soft_copy() staging: comedi: ni_tio: export and fix ni_tio_set_bits() staging: comedi: ni_tio_internal: simplify ni_tio_counting_mode_registers_present() staging: comedi: ni_tio_internal: export {read,write)_register() staging: comedi: ni_tio: tidy up struct ni_gpct_device (*{write,read}_register) staging: comedi: ni_tio.h: tidy up struct ni_gpct_device staging: comedi: ni_tio.h: tidy up struct ni_gpct staging: comedi: ni_tio.h: fix block comment staging: comedi: ni_tio.h: remove unnecessary forward declarations staging: comedi: ni_tio: Prefer 'unsigned int' to bare use of 'unsigned' staging: comedi: ni_tio: Prefer kernel type 'u64' over 'uint64_t' staging: comedi: ni_tio: fix block comments staging: comedi: ni_tio: tidy up ni_tio_get_gate_src() staging: comedi: ni_tio: tidy up ni_tio_set_sync_mode() staging: comedi: ni_tio: tidy up ni_tio_arm() staging: comedi: ni_tiocmd: Prefer 'unsigned int' to bare use of 'unsigned' staging: comedi: ni_tiocmd: fix block comments staging: comedi: ni_tiocmd: remove unsed param from ni_tio_acknowledge_and_confirm() staging: comedi: ni_tiocmd: remove BUG() which can never occur staging: comedi: ni_tio: validate clock source staging: comedi: ni_tio: remove BUG() checks for ni_tio_get_gate_src() staging: comedi: ni_tio: fix ni_tio_insn_config() staging: comedi: ni_tio: remove BUG() in ni_tio_set_gate_src() staging: comedi: ni_tio: remove BUG() checks for ni_tio_get_clock_src() drivers/staging/comedi/drivers/ni_tio.c | 805 +++++++++++++---------- drivers/staging/comedi/drivers/ni_tio.h | 66 +- drivers/staging/comedi/drivers/ni_tio_internal.h | 322 ++++----- drivers/staging/comedi/drivers/ni_tiocmd.c | 116 ++-- 4 files changed, 683 insertions(+), 626 deletions(-)
Thanks! Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
