The USB completion callbacks set the status field of an MBO object before
scheduling the clear_work. This patch removes this redundant assignment as
the work_struct does the same for all MBOs.

Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de>
Signed-off-by: Christian Gromm <christian.gr...@microchip.com>
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c 
b/drivers/staging/most/hdm-usb/hdm_usb.c
index 453b641..f44f27e 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -412,7 +412,6 @@ static void hdm_write_completion(struct urb *urb)
                        dev_warn(dev, "Broken OUT pipe detected\n");
                        mdev->is_channel_healthy[channel] = false;
                        spin_unlock_irqrestore(lock, flags);
-                       mbo->status = MBO_E_INVAL;
                        mdev->clear_work[channel].pipe = urb->pipe;
                        schedule_work(&mdev->clear_work[channel].ws);
                        return;
@@ -570,7 +569,6 @@ static void hdm_read_completion(struct urb *urb)
                        dev_warn(dev, "Broken IN pipe detected\n");
                        mdev->is_channel_healthy[channel] = false;
                        spin_unlock_irqrestore(lock, flags);
-                       mbo->status = MBO_E_INVAL;
                        mdev->clear_work[channel].pipe = urb->pipe;
                        schedule_work(&mdev->clear_work[channel].ws);
                        return;
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to