Jes Sorensen <> writes:

> Joe Perches <> writes:
>> On Sat, 2016-09-17 at 12:09 -0500, Larry Finger wrote:
>>> As soon as debugging is turned on, the logs are filled with messages
>>> reporting the interrupt status. As this quantity is usually zero, this
>>> output is not needed. In fact, there will be a report if the status is
>>> not zero, thus the debug line in question could probably be deleted.
>>> Rather than taking that action, I have changed it to only be printed
>>> when the RTL8XXXU_DEBUG_USB bit is set in the debug mask.
>> There are many uses of
>>      if (rtl8xxxu_debug & <DEFINE>) {
>>              dev_info(dev, ...)
>> Emitting debugging information at KERN_INFO is odd.
> Not at all, it's a pain to enable it in debug fs post loading the
> driver, especially if you need the output immediately during driver
> init. That is why the flags are there.
>> I think it'd be nicer to use dev_dbg for all these cases
>> and as well use some new macro that includes the test
>> Something like:
>> #define rtl8xxxu_dbg(type, fmt, ...)                 \
>> do {                                                 \
>>      if (rtl8xxxu_debug & (type))                    \
>>              dev_dbg(dev, fmt, ##__VA_ARGS__);       \
>> } while (0)
> Yuck yuck yuck, no thanks!
> Any attempt of adding that kinda grossness to the driver will get a

Huh, how is that ugly? To me it's the opposite, original code is ugly
and Joes' proposal makes sense. Lots of wireless drivers have something

Kalle Valo
devel mailing list

Reply via email to