On 18.10.2016 23:26, Ryan Swan wrote:
> As per discusion with Lino Sanfilippo, memcpy is the proper way to copy
> across dma memory, which also removes sparse warning that triggered
> inquiry.
> 
> Signed-off-by: Ryan Swan <r...@ryanswan.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c 
> b/drivers/staging/slicoss/slicoss.c
> index 2802b90..9a1dc72 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter 
> *adapter, u32 isr)
>               if (stats->rcv_drops > old->rcv_drops)
>                       adapter->rcv_drops += (stats->rcv_drops -
>                                              old->rcv_drops);
> -             memcpy_fromio(old, stats, sizeof(*stats));
> +             memcpy(old, stats, sizeof(*stats));
>               break;
>       }
>       case SLIC_UPR_RLSR:
> 

Reviewed-by: Lino Sanfilippo <linosanfili...@gmx.de>
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to