From: Andreas Dilger <andreas.dil...@intel.com>

In some cases with a very long pathname, such as with sanity.sh
test_154c, mdc_ioc_fid2path() would spew long debug messages to
the log, because libcfs_debug_vmsg2() refuses to log messages over
one page in size.

Truncate the debug message to only log the last 512 characters
of the pathname, which is sufficient for most debugging, saves a
bit of space in the debug log, and will prevent the debug logging
from printing to the console in the first place.

Signed-off-by: Andreas Dilger <andreas.dil...@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1095
Reviewed-on: http://review.whamcloud.com/17078
Reviewed-by: Jian Yu <jian...@intel.com>
Reviewed-by: Niu Yawei <yawei....@intel.com>
Reviewed-by: Oleg Drokin <oleg.dro...@intel.com>
Signed-off-by: James Simmons <jsimm...@infradead.org>
---
 drivers/staging/lustre/lustre/mdc/mdc_request.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index eee848d..6bed5ec 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -1455,8 +1455,11 @@ static int mdc_ioc_fid2path(struct obd_export *exp, 
struct getinfo_fid2path *gf)
                goto out;
        }
 
-       CDEBUG(D_IOCTL, "path get "DFID" from %llu #%d\n%s\n",
-              PFID(&gf->gf_fid), gf->gf_recno, gf->gf_linkno, gf->gf_path);
+       CDEBUG(D_IOCTL, "path got " DFID " from %llu #%d: %s\n",
+              PFID(&gf->gf_fid), gf->gf_recno, gf->gf_linkno,
+              gf->gf_pathlen < 512 ? gf->gf_path :
+              /* only log the last 512 characters of the path */
+              gf->gf_path + gf->gf_pathlen - 512);
 
 out:
        kfree(key);
-- 
1.7.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to