Re: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments

[Ian Abbott]

On 19/12/2016 14:36, devendra sharma wrote:
Added comments before memory barrier
Signed-off-by: Devendra Sharma <devendra.sharma9...@gmail.com>
---
  drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c 
b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index c9eb26f..c3b5236 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device 
*dev,

        mutex_lock(&devpriv->mutex);
        for (n = 0; n < insn->n; n++) {
+               /*multi-processor memory barrier*/
                smp_mb();

Thanks for the effort, but these comments add no useful information and 
serve only to silence the checkpatch warnings. Also, there is no space 
after the '/*' and before the '*/'.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel