> -----Original Message-----
> From: [email protected] [mailto:[email protected]]
> Sent: Tuesday, February 07, 2017 8:15 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected]; 
> [email protected]; Ioana
> Ciornei <[email protected]>; Ruxandra Ioana Radulescu 
> <[email protected]>; Bharat Bhushan
> <[email protected]>; Stuart Yoder <[email protected]>; Catalin 
> Horghidan
> <[email protected]>; Leo Li <[email protected]>; Roy Pledge 
> <[email protected]>; linux-arm-
> [email protected]; Laurentiu Tudor <[email protected]>
> Subject: [PATCH 00/10][v2] staging: fsl-mc: fixes and cleanups
> 
> From: Laurentiu Tudor <[email protected]>
> 
> First 4 patches fix several driver model related
> issues and drop an useless atomic global.
> The rest of the patches are cleanups mostly
> consisting in removing dead code.
> 
> v2:
>  - split slab cache removal in distinct patch
>  - redundant deallocation dropped in patch that adds release callback

Laurentiu,

A few nits about this submission:

-every patch in the series should have had "v2" in the patch
 subject.  In your submission only the cover letter had it.
 Without that it's harder to keep track of which version of
 patch I'm looking at.  Just use this when formatting your
 patches:
     --patch-subject="PATCH v2"

-for each patch, you should note below the "---" what changed in the
 patch, and if there were no changes you put "no changes".  For
 an example see:
     https://patchwork.kernel.org/patch/9478093/

 (You can use "git notes" to manage the below the "---" comments
  if it helps)

Can you reformat this series with "v3" and add the the comments
to note what did not change and what did change?

Thanks,
Stuart

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to