On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote:
> Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" 
> in vchiq_version.c file.
> 
> Signed-off-by: Yamanappagouda Patil <goudapat...@gmail.com>
> ---
>  .../vc04_services/interface/vchiq_arm/vchiq_version.c    | 16 
> ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git 
> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c 
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
[]
> @@ -33,27 +33,27 @@
>  #include "vchiq_build_info.h"
>  #include <linux/broadcom/vc_debug_sym.h>
>  
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, 
> "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time,    __TIME__ );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date,    __DATE__ );
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01");
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, 
> "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)");
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time,    __TIME__);
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date,    __DATE__);

Uses of __TIME__ and __DATE__ make it
impossible to have repeatable builds.

Are these __TIME__ and __DATE__ uses
really useful and necessary?

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to